karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.14k stars 812 forks source link

upgrade arduino/setup-protoc from v1 to v3 #4881

Closed chaosi-zju closed 2 weeks ago

chaosi-zju commented 2 weeks ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

upgrade arduino/setup-protoc from v1 to v3.

For related discussion see #4856

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.06%. Comparing base (81916d6) to head (44cd912). Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4881 +/- ## ========================================== - Coverage 53.07% 53.06% -0.01% ========================================== Files 251 251 Lines 20389 20389 ========================================== - Hits 10821 10819 -2 - Misses 8855 8856 +1 - Partials 713 714 +1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4881/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4881/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.06% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

liangyuanpeng commented 2 weeks ago

/lgtm /approve

Thanks.

karmada-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[.github/workflows/OWNERS](https://github.com/karmada-io/karmada/blob/master/.github/workflows/OWNERS)~~ [liangyuanpeng] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
liangyuanpeng commented 2 weeks ago

I have not get that why it is flake.

/kind cleanup

RainbowMango commented 2 weeks ago

Yes, you are right. It's not a flake.