Closed guozheng-shen closed 1 week ago
Welcome @guozheng-shen! It looks like this is your first PR to karmada-io/karmada 🎉
@XiShanYongYe-Chang ok, it's done, pls review again, Thanks.
Hi @guozheng-shen can you help describe how we can use OIDC for certification with this PR?
@XiShanYongYe-Chang Our kubeconfig uses oidc to access the k8s cluster. When I use karmadactl to join my member cluster, an error occurs causing the member cluster to fail to join (panic: No Auth provider found for the name "oidc", we need to import (_"k8s.io/client-go/plugin/pkg/client/auth/oidc") when karmadactl run. It will provide a newOIDCAuthProvider
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.13%. Comparing base (
fff3699
) to head (82ac4ef
). Report is 22 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/assign
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this? /kind feature
What this PR does / why we need it: In our clusters, OIDC authentication is required for cluster operation auditing and access control. This is also a common authentication method. I believe it can be integrated into Karmada. Which issue(s) this PR fixes: NONE Special notes for your reviewer:
Does this PR introduce a user-facing change?: