karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.14k stars 811 forks source link

Bump Kubernetes dependencies to v1.29.4 #4884

Closed RainbowMango closed 1 week ago

RainbowMango commented 2 weeks ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR bumps Kubernetes dependencies to v1.29.4.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.14%. Comparing base (5e1191f) to head (64f2cc6).

Files Patch % Lines
pkg/controllers/status/common.go 0.00% 1 Missing :warning:
pkg/controllers/status/work_status_controller.go 0.00% 1 Missing :warning:
...er/customized/declarative/configmanager/manager.go 0.00% 1 Missing :warning:
...esourceinterpreter/default/native/reflectstatus.go 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4884 +/- ## ========================================== + Coverage 53.13% 53.14% +0.01% ========================================== Files 251 251 Lines 20417 20415 -2 ========================================== + Hits 10848 10849 +1 + Misses 8855 8853 -2 + Partials 714 713 -1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4884/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4884/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.14% <33.33%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RainbowMango commented 1 week ago

This PR is now blocked by the issue that karmada-metrics-adapter failed to startup due to:

E0429 02:35:01.375275       1 options.go:104] Unable to construct metrics adapter: unable to construct lister client config to initialize provider: open /var/run/secrets/kubernetes.io/serviceaccount/token: no such file or directory
E0429 02:35:01.375304       1 run.go:74] "command failed" err="unable to construct lister client config to initialize provider: open /var/run/secrets/kubernetes.io/serviceaccount/token: no such file or directory"
RainbowMango commented 1 week ago

Another error is:

-bash-5.0# kubectl apply -f examples/customresourceinterpreter/apis/workload.example.io_workloads.yaml 
The CustomResourceDefinition "workloads.workload.example.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes
RainbowMango commented 1 week ago

This is the minimum changes for updating Kubernetes dependencies to v1.29.4 :) After this we still need to update dependencies like:

karmada-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment