codecov-commenter
commented
2 weeks ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.06%. Comparing base (
95bf37f) to head (f5de886).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #4885 +/- ## ========================================== - Coverage 53.07% 53.06% -0.01% ========================================== Files 251 251 Lines 20389 20389 ========================================== - Hits 10821 10820 -1 Misses 8855 8855 - Partials 713 714 +1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4885/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4885/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.06% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
zhzhuang-zju
karmada-bot
whitewindmills
What type of PR is this? /kind cleanup
What this PR does / why we need it: Refer to #4868, when
karmada-webhookis started, the errorlog.SetLogger(...) was never called; logs will not be displayedwill be displayed, which is very confusing. Here's the answer to why this log appears and how to fix it. Viewing the function call chain, refer to: https://github.com/karmada-io/karmada/blob/95bf37f4d4b82cd9ab68e5879020c070acec1ce0/vendor/sigs.k8s.io/controller-runtime/pkg/webhook/admission/webhook.go#L178-L184 If the log of webhook is nil, it will end up calling https://github.com/karmada-io/karmada/blob/95bf37f4d4b82cd9ab68e5879020c070acec1ce0/vendor/sigs.k8s.io/controller-runtime/pkg/log/log.go#L54-L72 And theSetLoggeris not called within the first 30 seconds of a binaries lifetime, finally printed outlog.SetLogger(...) was never called; logs will not be displayederror. Through the above analysis, there are two ways to solve this problem：Initializing the webhook's log Looking at the source code, there are two ways to initialize, in addition to the one above, there is one as follows: https://github.com/karmada-io/karmada/blob/95bf37f4d4b82cd9ab68e5879020c070acec1ce0/vendor/sigs.k8s.io/controller-runtime/pkg/webhook/admission/webhook.go#L216-L233 Since this initialization method does not apply to
webhook.Server, this method does not workcall
SetLoggerto get any actual logging. That's what I ended up using, by callingSetLoggerfirst to silence the 'log.SetLogger(...) was never called; logs will not be displayed' error.BTW, it was a breaking change in the release notes
0.15.0ofcontroller-runtime. Previously, when thepkg/logpackage was imported, there was aninitfunction that spawned a goroutine, which set a null logger after 30 seconds. Therefore, versions prior to0.15.0will not have this problem.Which issue(s) this PR fixes: Fixes #4868
Special notes for your reviewer:
Does this PR introduce a user-facing change?: