Open liangyuanpeng opened 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.14%. Comparing base (
a8697ec
) to head (9a32daa
). Report is 2 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng
in a comment when ready.
The full list of commands accepted by this bot can be found here.
cc @zhzhuang-zju
@liangyuanpeng By looking at the logs uploaded by CI, I found that the versions of karmada-apiserver
are both v1.25.4
and have not changed based on the configured environment variables. Can you help confirm this?
we need to cherry pick this change to branch of release, and then it can be working for release branch, i update the trigger branch to master for verify.
we need to cherry pick this change to branch of release, a
Yes, changes to files karmada-apiserver.yaml
, kube-controller-manager.yaml
and deploy-karmada.sh
should be synchronized to previous release versions.
@liangyuanpeng It would be nice to have an issue to break down and track this task, which would also make the whole work clearer
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The workflow of APIServer compatibility is failing when it's running with master, see
The reason is master is running with karmada-apiserver v1.27.11, and the workflow of
APIServer compatibility
is change the version of karmada-apiserver by patching karmada-apiserver, and actually it's happening the downgrade/upgrade of karmada-apiserver, it's always failing if karmada-apiserver have add some new API. For now, it'sflowcontrol.apiserver.k8s.io/v1beta3
, available with v1.26, so it will always failed if karmada-apiserver downgrade to lessthan v1.26So this PR is working for useing environment to config the karmada-apiserver version, Avoid karmada-apiserver downgrade/upgrade happening.
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
This PR CI is failing with the confict artifact name, will resolve by https://github.com/karmada-io/karmada/pull/4897
Does this PR introduce a user-facing change?: