karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.14k stars 812 forks source link

chore: let kube version of artifaces/deploy/karmada-apiserver versionsupport configuration. #4899

Open liangyuanpeng opened 1 week ago

liangyuanpeng commented 1 week ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The workflow of APIServer compatibility is failing when it's running with master, see

The reason is master is running with karmada-apiserver v1.27.11, and the workflow of APIServer compatibility is change the version of karmada-apiserver by patching karmada-apiserver, and actually it's happening the downgrade/upgrade of karmada-apiserver, it's always failing if karmada-apiserver have add some new API. For now, it's flowcontrol.apiserver.k8s.io/v1beta3, available with v1.26, so it will always failed if karmada-apiserver downgrade to lessthan v1.26

So this PR is working for useing environment to config the karmada-apiserver version, Avoid karmada-apiserver downgrade/upgrade happening.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

This PR CI is failing with the confict artifact name, will resolve by https://github.com/karmada-io/karmada/pull/4897

Does this PR introduce a user-facing change?:

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.14%. Comparing base (a8697ec) to head (9a32daa). Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4899 +/- ## ========================================== + Coverage 53.12% 53.14% +0.01% ========================================== Files 251 251 Lines 20415 20415 ========================================== + Hits 10845 10849 +4 + Misses 8856 8853 -3 + Partials 714 713 -1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4899/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4899/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.14% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karmada-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed. You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
RainbowMango commented 1 week ago

cc @zhzhuang-zju

zhzhuang-zju commented 1 week ago

@liangyuanpeng By looking at the logs uploaded by CI, I found that the versions of karmada-apiserver are both v1.25.4 and have not changed based on the configured environment variables. Can you help confirm this?

liangyuanpeng commented 1 week ago

we need to cherry pick this change to branch of release, and then it can be working for release branch, i update the trigger branch to master for verify.

zhzhuang-zju commented 1 week ago

we need to cherry pick this change to branch of release, a

Yes, changes to files karmada-apiserver.yaml, kube-controller-manager.yamland deploy-karmada.sh should be synchronized to previous release versions.

@liangyuanpeng It would be nice to have an issue to break down and track this task, which would also make the whole work clearer

liangyuanpeng commented 1 week ago

tracking at https://github.com/karmada-io/karmada/issues/4929