karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.14k stars 813 forks source link

add e2e for FederatedHPA and metrics-adapter #4903

Closed chaosi-zju closed 6 days ago

chaosi-zju commented 1 week ago

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

add e2e for FederatedHPA and metrics-adapter.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

chaosi-zju commented 1 week ago

@chaunceyjiang can you help reviewing this PR?

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.17%. Comparing base (4ccffcc) to head (b3ccd3b).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4903 +/- ## ========================================== - Coverage 53.18% 53.17% -0.02% ========================================== Files 252 252 Lines 20510 20510 ========================================== - Hits 10909 10906 -3 - Misses 8882 8884 +2 - Partials 719 720 +1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/4903/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/4903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.17% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chaosi-zju commented 1 week ago

ready

cc @RainbowMango

RainbowMango commented 1 week ago

cc test owners /assign @XiShanYongYe-Chang @Vacant2333

chaosi-zju commented 1 week ago

@XiShanYongYe-Chang comments all fixed.

RainbowMango commented 6 days ago

/approve

karmada-bot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/karmada-io/karmada/blob/master/test/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment