karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.14k stars 813 forks source link

Bump metrics-server to v0.7.1 #4904

Closed RainbowMango closed 1 week ago

RainbowMango commented 1 week ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates the metrics-server and pin to the released version.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
RainbowMango commented 1 week ago

@chaosi-zju Can you help to run the test against karmada-metrics-adapter?

chaosi-zju commented 1 week ago

@chaosi-zju Can you help to run the test against karmada-metrics-adapter?

This PR has passed my testing.

I did the test by following steps:

  1. fetch the code of this PR.
  2. reinstall karmada locally.
  3. run the e2e test of #4903 locally.
e2e test log ```shell • [125.304 seconds] testing for FederatedHPA and metrics-adapter FederatedHPA scale Deployment do scale when deployment metrics of cpu/mem utilization up /root/home/gopath/src/github.com/chaosi-zju/karmada/test/e2e/federatedhpa_test.go:109 Captured StdOut/StdErr Output >> I0508 10:44:55.073166 824965 pod.go:60] Waiting for pod(karmadatest-6jkj5/deploy-jqglk) synced on cluster(member1) I0508 10:45:40.130502 824965 pod.go:110] Waiting for pod(karmadatest-6jkj5/deploy-jqglk) disappear on cluster(member1) I0508 10:46:15.214008 824965 deployment.go:123] Waiting for deployment(karmadatest-6jkj5/deploy-jqglk) disappears on cluster(member1) I0508 10:46:20.222504 824965 service.go:79] Waiting for service(karmadatest-6jkj5/deploy-jqglk) disappear on cluster(member1) << Captured StdOut/StdErr Output Timeline >> STEP: Creating ClusterPropagationPolicy(deploy-jqglk) @ 05/08/24 10:44:14.921 STEP: Creating Deployment(karmadatest-6jkj5/deploy-jqglk) @ 05/08/24 10:44:14.935 STEP: Creating Service(karmadatest-6jkj5/deploy-jqglk) @ 05/08/24 10:44:14.97 STEP: Create FederatedHPA(karmadatest-6jkj5/deploy-jqglk) @ 05/08/24 10:44:14.987 STEP: step1: check initial replicas result should equal to 1 @ 05/08/24 10:44:15.014 STEP: Waiting for deployment(karmadatest-6jkj5/deploy-jqglk) status to have 1 replicas @ 05/08/24 10:44:15.014 STEP: step2: pressure test the deployment of member clusters to increase the cpu/mem @ 05/08/24 10:44:55.061 STEP: Creating Pod(karmadatest-6jkj5/deploy-jqglk) @ 05/08/24 10:44:55.061 STEP: step3: check final replicas result should greater than 1 @ 05/08/24 10:45:00.081 STEP: Removing Pod(karmadatest-6jkj5/deploy-jqglk) @ 05/08/24 10:45:40.12 STEP: Remove FederatedHPA(karmadatest-6jkj5/deploy-jqglk) @ 05/08/24 10:46:15.18 STEP: Removing Service(karmadatest-6jkj5/deploy-jqglk) @ 05/08/24 10:46:15.188 STEP: Removing Deployment(karmadatest-6jkj5/deploy-jqglk) @ 05/08/24 10:46:15.201 STEP: Removing ClusterPropagationPolicy(deploy-jqglk) @ 05/08/24 10:46:15.206 << Timeline ------------------------------ [SynchronizedAfterSuite] PASSED [0.005 seconds] [SynchronizedAfterSuite] /root/home/gopath/src/github.com/chaosi-zju/karmada/test/e2e/suite_test.go:167 ```
RainbowMango commented 1 week ago

OK. thanks. Then we can move forward now.

karmada-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment