search

karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.37k stars 865 forks source link

Automated cherry pick of #5188: Fix the issue of residual work in the MultiClusterService #5213

Closed XiShanYongYe-Chang closed 1 month ago

XiShanYongYe-Chang commented 1 month ago

Cherry pick of #5188 on release-1.8.

5188: Fix the issue of residual work in the MultiClusterService

For details on the cherry pick process, see the cherry pick requests page.

karmada-controller-manager: fix the issue of residual work in the MultiClusterService feature.
RainbowMango commented 1 month ago

The test is failing, seems releated:

STEP: Creating MultiClusterService(karmadatest-k7rxx/mcs-84vtk) @ 07/17/24 08:09:54.947
  STEP: Creating PropagationPolicy(karmadatest-k7rxx/mcs-8m7w7) @ 07/17/24 08:09:54.959
  STEP: Creating Pod(karmadatest-k7rxx/mcs-8m7w7) @ 07/17/24 08:09:54.969
  STEP: Creating Deployment(karmadatest-k7rxx/mcs-8m7w7) @ 07/17/24 08:09:54.976
  STEP: Creating Service(karmadatest-k7rxx/mcs-84vtk) @ 07/17/24 08:09:54.981
  STEP: Waiting for pod(karmadatest-k7rxx/mcs-8m7w7) synced on member clusters @ 07/17/24 08:09:54.998
  STEP: Waiting for deployment(karmadatest-k7rxx/mcs-8m7w7) synced on member clusters @ 07/17/24 08:10:00.011
  [FAILED] in [It] - /home/runner/work/karmada/karmada/test/e2e/mcs_test.go:713 @ 07/17/24 08:15:00.022
  STEP: Removing MultiClusterService(karmadatest-k7rxx/mcs-84vtk) @ 07/17/24 08:15:00.022
  STEP: Removing PropagationPolicy(karmadatest-k7rxx/mcs-8m7w7) @ 07/17/24 08:15:00.043
  STEP: Removing Pod(karmadatest-k7rxx/mcs-8m7w7) @ 07/17/24 08:15:00.049
  STEP: Removing Deployment(karmadatest-k7rxx/mcs-8m7w7) @ 07/17/24 08:15:05.067
  STEP: Removing Service(karmadatest-k7rxx/mcs-84vtk) @ 07/17/24 08:15:05.07
  << Timeline

  [FAILED] Timed out after 300.001s.
  Expected
      <bool>: false
  to be true
  In [It] at: /home/runner/work/karmada/karmada/test/e2e/mcs_test.go:713 @ 07/17/24 08:15:00.022

  Full Stack Trace
    github.com/karmada-io/karmada/test/e2e.glob..func20.6.3()
        /home/runner/work/karmada/karmada/test/e2e/mcs_test.go:713 +0x403
karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/controllers/OWNERS](https://github.com/karmada-io/karmada/blob/release-1.8/pkg/controllers/OWNERS)~~ [RainbowMango] - ~~[pkg/util/OWNERS](https://github.com/karmada-io/karmada/blob/release-1.8/pkg/util/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment