karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.37k stars 865 forks source link

Adding generic handling of priorityclass + namespace for flinkdeployment interpreter #5215

Closed mszacillo closed 1 month ago

mszacillo commented 1 month ago

What type of PR is this? /kind feature

What this PR does / why we need it: The default interpreter for FlinkDeployment does not currently account for namespace or priorityclass. This was done because in our use-case, the priorityclass is shared amongst tenants and can be set statically. But after thinking again, it makes more sense to have this interpretation be generic.

This is a quick PR that adds that capability.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added generic handling of priorityclass and namespace for default flinkdeployment interpreter
codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.24%. Comparing base (8859cb9) to head (d79c600). Report is 12 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5215 +/- ## ========================================== - Coverage 28.25% 28.24% -0.01% ========================================== Files 632 632 Lines 43722 43723 +1 ========================================== - Hits 12354 12351 -3 - Misses 30465 30469 +4 Partials 903 903 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/5215/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/5215/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `28.24% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yike21

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/resourceinterpreter/default/thirdparty/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/resourceinterpreter/default/thirdparty/OWNERS)~~ [yike21] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment