Open yanfeng1992 opened 1 month ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign garrybest for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/retest
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 0%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 28.24%. Comparing base (
a87ec2a
) to head (5a4f42b
). Report is 8 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
.../framework/plugins/apienablement/api_enablement.go | 0.00% | 5 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for your feedback @yanfeng1992
Because when obtaining APIEnablements, it may be empty or partial.
When will that happen?
When will that happen?
I guess it's when the status of AA is false?
When will that happen?
I guess it's when the status of AA is false?
When the AA status is false and the cluster status is healthy
Thanks @chaunceyjiang @yanfeng1992 , I get it.
/assign @XiShanYongYe-Chang
Signed-off-by: huangyanfeng huangyanfeng1992@gmail.com
What type of PR is this? /kind bug
What this PR does / why we need it:
Because when obtaining APIEnablements, it may be empty or partial. This will cause the scheduler to delete the scheduling results, resulting in incorrect deletion
So if the cluster is already in the list of scheduling results, even if the API is not hit, skip the filter
https://github.com/karmada-io/karmada/blob/a87ec2a61abadf9f102440b1f64cf338b2ee5518/pkg/controllers/status/cluster_status_controller.go#L233-L239
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: