karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.37k stars 865 forks source link

test/e2e/karmadactl_test.go: test options command #5221

Closed mohamedawnallah closed 1 month ago

mohamedawnallah commented 1 month ago

Description

In this commit, we test karmadactl options on listing all available global options successfully and returning an error for the invalid flag in options.

What type of PR is this?

/kind failing-test

Which issue(s) this PR fixes:

Part of #4544

Does this PR introduce a user-facing change?:

NONE
codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.26%. Comparing base (5e3e5ad) to head (cb43384).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5221 +/- ## ======================================= Coverage 28.25% 28.26% ======================================= Files 632 632 Lines 43739 43739 ======================================= + Hits 12360 12361 +1 Misses 30478 30478 + Partials 901 900 -1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/5221/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/5221/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `28.26% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karmada-bot commented 1 month ago

@mohamedawnallah: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/karmada-io/karmada/pull/5221#issuecomment-2235790055): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mohamedawnallah commented 1 month ago

/retest

karmada-bot commented 1 month ago

@mohamedawnallah: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/karmada-io/karmada/pull/5221#issuecomment-2235791488): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
zhzhuang-zju commented 1 month ago

/retest ask @XiShanYongYe-Chang to take a look

zhzhuang-zju commented 1 month ago

LGTM, but you might solve the merge conflict first

mohamedawnallah commented 1 month ago

@zhzhuang-zju @XiShanYongYe-Chang Let's get this merged first #5210 since it is submitted first and rebase on it?

mohamedawnallah commented 1 month ago

I just rebased on the master branch in case of asynchronous merging for PRs. I will ask for review when GitHub CI tests finish!

XiShanYongYe-Chang commented 1 month ago

/assign @zhzhuang-zju @Vacant2333

zhzhuang-zju commented 1 month ago

/lgtm cc @XiShanYongYe-Chang @Vacant2333

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/karmada-io/karmada/blob/master/test/OWNERS)~~ [XiShanYongYe-Chang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment