Closed mohamedawnallah closed 1 month ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 28.26%. Comparing base (
5e3e5ad
) to head (cb43384
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mohamedawnallah: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
/retest
@mohamedawnallah: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
/retest ask @XiShanYongYe-Chang to take a look
LGTM, but you might solve the merge conflict first
@zhzhuang-zju @XiShanYongYe-Chang Let's get this merged first #5210 since it is submitted first and rebase on it?
I just rebased on the master
branch in case of asynchronous merging for PRs. I will ask for review when GitHub CI tests finish!
/assign @zhzhuang-zju @Vacant2333
/lgtm cc @XiShanYongYe-Chang @Vacant2333
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: XiShanYongYe-Chang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Description
In this commit, we test
karmadactl options
on listing all available global options successfully and returning an error for the invalid flag in options.What type of PR is this?
/kind failing-test
Which issue(s) this PR fixes:
Part of #4544
Does this PR introduce a user-facing change?: