karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.37k stars 865 forks source link

Standardize the health probe arguments #5223

Closed whitewindmills closed 1 month ago

whitewindmills commented 1 month ago

What type of PR is this? /kind deprecation /kind feature /kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes: part of https://github.com/karmada-io/karmada/issues/5219

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-agent`:  Add health probe argument `health-probe-bind-address`, deprecate `--bind-address` and `--secure-port` flag.
whitewindmills commented 1 month ago

/assign @RainbowMango @zhzhuang-zju

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 28.22%. Comparing base (1bf9336) to head (955b5b5). Report is 18 commits behind head on master.

Files Patch % Lines
cmd/agent/app/options/options.go 0.00% 7 Missing :warning:
cmd/agent/app/agent.go 0.00% 3 Missing :warning:
pkg/karmadactl/register/register.go 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5223 +/- ## ========================================== - Coverage 28.23% 28.22% -0.01% ========================================== Files 632 632 Lines 43739 43738 -1 ========================================== - Hits 12349 12347 -2 - Misses 30486 30487 +1 Partials 904 904 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/5223/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/5223/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `28.22% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

whitewindmills commented 1 month ago

@RainbowMango @zhzhuang-zju PTAL

zhzhuang-zju commented 1 month ago

/retest

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment