karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.37k stars 865 forks source link

Only update krew index for latest stable version. #5224

Closed liangyuanpeng closed 1 week ago

liangyuanpeng commented 1 month ago

What type of PR is this?

/kind cleanup What this PR does / why we need it:

Only update krew index for latest stable version. Avoid sending noisy PRs and in the future,we don't need some PR anymore like:

/cc @RainbowMango @zhzhuang-zju

Which issue(s) this PR fixes:

Ref https://github.com/karmada-io/karmada/issues/4703 Fixes #

Special notes for your reviewer:

Tested on my fork repo:

Does this PR introduce a user-facing change?:

NONE
codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 31.47%. Comparing base (a61d36a) to head (31177dd). Report is 30 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5224 +/- ## ========================================== + Coverage 31.14% 31.47% +0.33% ========================================== Files 640 643 +3 Lines 44417 44436 +19 ========================================== + Hits 13833 13987 +154 + Misses 29583 29423 -160 - Partials 1001 1026 +25 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/5224/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/5224/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `31.47% <ø> (+0.33%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zhzhuang-zju commented 1 month ago

@liangyuanpeng What a coincidence, we must have been on the same wavelength! Thanks for your job, and review is ongoing~

liangyuanpeng commented 1 week ago

ping @zhzhuang-zju for review :)

zhzhuang-zju commented 1 week ago

/assign

zhzhuang-zju commented 1 week ago

/lgtm cc @RainbowMango

RainbowMango commented 1 week ago

/retest

karmada-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[.github/workflows/OWNERS](https://github.com/karmada-io/karmada/blob/master/.github/workflows/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment