Closed mohamedawnallah closed 1 month ago
@mohamedawnallah: The label(s) kind/[not, kind/sure, kind/if, kind/this, kind/is, kind/the, kind/correct, kind/kind, kind/of, kind/pr!]
cannot be applied, because the repository doesn't have them.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 28.26%. Comparing base (
871e2bf
) to head (2a55c98
). Report is 2 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mohamedawnallah Thanks~ Good Job. /cc @Vacant2333 @zhzhuang-zju
thanks~ cc @Vacant2333 @XiShanYongYe-Chang /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: XiShanYongYe-Chang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thanks @XiShanYongYe-Chang! For full context, There was one place where we hard-code cluster names in test package: https://github.com/karmada-io/karmada/blob/61a3d1f815859630d9bda0160f1082dd69802714/test/helper/policy.go#L175-L190
I tried to use framework.ClusterNames()
but it causes import cycle since it is used in framework
package. Should we do anything about it?
You can try to use the input parameter to transfer the cluster information.
@XiShanYongYe-Chang Okay gonna submit a follow-up patch for this 👍
Description
Unify access to cluster members utilizing
framework.ClusterMembers()[i]
.What type of PR is this?
/kind cleanup [not sure if this is the correct kind of PR!]
Which issue(s) this PR fixes:
Motivated by @XiShanYongYe-Chang's comment: https://github.com/karmada-io/karmada/pull/5195#discussion_r1680354650
Does this PR introduce a user-facing change?: