karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.44k stars 880 forks source link

test: unify access to cluster members utilizing `framework.ClusterMembers()` as input parameter #5239

Closed mohamedawnallah closed 2 months ago

mohamedawnallah commented 2 months ago

Description

In this commit, we unify access to cluster members in test/helper by passing clusterNames as an input parameter to the function NewFederatedResourceQuota. This commit is also a follow-up of this PR #5226.

What type of PR is this?

/kind cleanup

Which issue(s) this PR fixes:

Motivated by @XiShanYongYe-Chang's comment: https://github.com/karmada-io/karmada/pull/5226#issuecomment-2238613211

Does this PR introduce a user-facing change?:

NONE
codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.27%. Comparing base (721495d) to head (f71bc13).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5239 +/- ## ========================================== + Coverage 28.26% 28.27% +0.01% ========================================== Files 632 632 Lines 43732 43732 ========================================== + Hits 12359 12364 +5 + Misses 30472 30467 -5 Partials 901 901 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/5239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/5239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `28.27% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karmada-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/karmada-io/karmada/blob/master/test/OWNERS)~~ [XiShanYongYe-Chang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment