Closed grosser closed 1 month ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 0%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 28.26%. Comparing base (
721495d
) to head (13f0f6e
). Report is 12 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
pkg/controllers/cluster/cluster_controller.go | 0.00% | 3 Missing :warning: |
pkg/karmadactl/util/idempotency.go | 0.00% | 3 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
updated to make every callsite of CreateOrUpdateNamespace set the labels, not sure what other changed we'd need
Hi @grosser, the CI-lint is failed. Can you help fix it?
make lint
to run locally that fixes things
golangci/golangci-lint info installed /Users/mgrosser/go/bin/golangci-lint
hack/verify-staticcheck.sh: line 36: golangci-lint: command not found
Please review the above warnings.
... I can make a PR for that
lint is happy now
/cc @chaunceyjiang
Thanks /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: XiShanYongYe-Chang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/kind feature
What this PR does / why we need it:
followup to https://github.com/karmada-io/karmada/pull/4620 where this was not added
Special notes for your reviewer:
Does this PR introduce a user-facing change?: