karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.37k stars 865 forks source link

add karmada.io/system label to created execution namespaces #5243

Closed grosser closed 1 month ago

grosser commented 1 month ago

/kind feature

What this PR does / why we need it:

followup to https://github.com/karmada-io/karmada/pull/4620 where this was not added

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- add karmada.io/system=true label to newly created karmada-es-* namespaces
codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 28.26%. Comparing base (721495d) to head (13f0f6e). Report is 12 commits behind head on master.

Files Patch % Lines
pkg/controllers/cluster/cluster_controller.go 0.00% 3 Missing :warning:
pkg/karmadactl/util/idempotency.go 0.00% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5243 +/- ## ======================================= Coverage 28.26% 28.26% ======================================= Files 632 632 Lines 43732 43738 +6 ======================================= + Hits 12359 12362 +3 - Misses 30472 30475 +3 Partials 901 901 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/5243/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/5243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `28.26% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

grosser commented 1 month ago

updated to make every callsite of CreateOrUpdateNamespace set the labels, not sure what other changed we'd need

XiShanYongYe-Chang commented 1 month ago

Hi @grosser, the CI-lint is failed. Can you help fix it?

grosser commented 1 month ago

Please review the above warnings.



... I can make a PR for that
grosser commented 1 month ago

lint is happy now

XiShanYongYe-Chang commented 1 month ago

/cc @chaunceyjiang

XiShanYongYe-Chang commented 1 month ago

Thanks /approve

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/controllers/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/controllers/OWNERS)~~ [XiShanYongYe-Chang] - ~~[pkg/karmadactl/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/karmadactl/OWNERS)~~ [XiShanYongYe-Chang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment