karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.44k stars 880 forks source link

relabel webhooks to make it obvious they belong to karmada #5246

Closed grosser closed 2 months ago

grosser commented 2 months ago

/kind feature

What this PR does / why we need it:

spilling out a part of https://github.com/karmada-io/karmada/pull/5240

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-webhook`: Changed "app" label from mutating-config/validating-config to karmada-webhook to make them identifiyable
codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.26%. Comparing base (bc1c96e) to head (afc1e5f).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5246 +/- ## ======================================= Coverage 28.26% 28.26% ======================================= Files 632 632 Lines 43732 43732 ======================================= + Hits 12360 12363 +3 + Misses 30470 30469 -1 + Partials 902 900 -2 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/5246/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/5246/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `28.26% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

XiShanYongYe-Chang commented 2 months ago

Hi @grosser, can you help add the component name in the release note, and describe it a little more precisely?

XiShanYongYe-Chang commented 2 months ago

/assign @chaunceyjiang @whitewindmills

grosser commented 2 months ago

updated, lmk if that's good or what you had in mind

XiShanYongYe-Chang commented 2 months ago

How about this relase-note:

karmada-webhook: changed "app" label from mutating-config/validating-config to karmada-webhook to make them identifiyable
XiShanYongYe-Chang commented 2 months ago

/release-note-edit karmada-webhook: changed "app" label from mutating-config/validating-config to karmada-webhook to make them identifiyable

It seems that it does not work.

grosser commented 2 months ago

updated

XiShanYongYe-Chang commented 2 months ago

Thanks /approve

karmada-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)~~ [XiShanYongYe-Chang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment