karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.44k stars 880 forks source link

test/e2e/karmadactl_test.go: test apply command #5250

Closed mohamedawnallah closed 1 month ago

mohamedawnallah commented 2 months ago

Description

In this commit, we add e2e tests for the karmadactl apply command to ensure it handles various scenarios correctly. The tests include:

What type of PR is this?

/kind failing-test

Which issue(s) this PR fixes:

Part of #4544

Does this PR introduce a user-facing change?:

NONE
codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.82%. Comparing base (6318541) to head (c325eee). Report is 7 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5250 +/- ## ========================================== + Coverage 29.67% 29.82% +0.15% ========================================== Files 632 632 Lines 43936 43936 ========================================== + Hits 13037 13106 +69 + Misses 29954 29873 -81 - Partials 945 957 +12 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/5250/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/5250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `29.82% <ø> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mohamedawnallah commented 2 months ago

Trying to close the PR and re-open for flaky test cases e2e test (v1.30.0) to succeed!

mohamedawnallah commented 2 months ago

It seems all test cases passed now :)

zhzhuang-zju commented 2 months ago

/assign

zhzhuang-zju commented 1 month ago

/lgtm cc @XiShanYongYe-Chang

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/karmada-io/karmada/blob/master/test/OWNERS)~~ [XiShanYongYe-Chang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment