Open Dyex719 opened 1 month ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi All, I have implemented and tested the failover information feature and wanted to request a review from the community on what changes might be required. I notice that there are some minor linter issues that I will fix. I have also addressed the failing test case in the comment above.
Thank you!
Hi @RainbowMango ! Could we get a review of this PR when you get a chance? Failures are due to the test case describes above in the comments. We can decide how to tackle this moving forward. Greatly appreciate it!
Sure. And sorry for letting this sit again!
What type of PR is this? /kind feature
What this PR does / why we need it: Adding failover history information so that applications can keep a record of what failovers happened in the past. Stateful applications can use this information to detect failures and continue processing from a particular state
Which issue(s) this PR fixes: Fixes #5116 #4969
Special notes for your reviewer:
Does this PR introduce a user-facing change?: