karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.37k stars 865 forks source link

Add failover history information #5251

Open Dyex719 opened 1 month ago

Dyex719 commented 1 month ago

What type of PR is this? /kind feature

What this PR does / why we need it: Adding failover history information so that applications can keep a record of what failovers happened in the past. Stateful applications can use this information to detect failures and continue processing from a particular state

Which issue(s) this PR fixes: Fixes #5116 #4969

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/karmada-io/karmada/blob/master/OWNERS)** - **[pkg/apis/OWNERS](https://github.com/karmada-io/karmada/blob/master/pkg/apis/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Dyex719 commented 1 month ago

Hi All, I have implemented and tested the failover information feature and wanted to request a review from the community on what changes might be required. I notice that there are some minor linter issues that I will fix. I have also addressed the failing test case in the comment above.

Thank you!

mszacillo commented 1 day ago

Hi @RainbowMango ! Could we get a review of this PR when you get a chance? Failures are due to the test case describes above in the comments. We can decide how to tackle this moving forward. Greatly appreciate it!

RainbowMango commented 17 hours ago

Sure. And sorry for letting this sit again!