fix: kustomize syntax for webhook caBundle

a7i commented 2 months ago

What type of PR is this? /kind cleanup

What this PR does / why we need it: The current syntax does not work for kustomize

❯ kustomize build charts/karmada/_crds/
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
Error: wrong node kind: expected ScalarNode but got MappingNode: node contents:
{? {caBundle: ''} : ''}

Adding quotes around it makes it work for kustomize build while still working for helm charts. This is a no risk change for those that prefer using kustomize.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.26%. Comparing base (4ba18c1) to head (994b477). Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #5253 +/- ## ========================================== + Coverage 28.24% 28.26% +0.01% ========================================== Files 632 632 Lines 43732 43732 ========================================== + Hits 12353 12360 +7 + Misses 30476 30471 -5 + Partials 903 901 -2 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/5253/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/5253/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `28.26% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karmada-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[charts/OWNERS](https://github.com/karmada-io/karmada/blob/master/charts/OWNERS)~~ [XiShanYongYe-Chang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

karmada-io / karmada

fix: kustomize syntax for webhook caBundle #5253

Codecov Report