karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.37k stars 865 forks source link

fix unexpected interference between different e2e use cases #5255

Closed chaosi-zju closed 1 month ago

chaosi-zju commented 1 month ago

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

The scope of some Policy's resourceSelector in E2E use case is too large to affect other use cases.

detail refer to #5256

Which issue(s) this PR fixes:

Fixes #5256

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

XiShanYongYe-Chang commented 1 month ago

A little more background on the problem?

chaosi-zju commented 1 month ago

A little more background on the problem?

yes, I will add a issue to describe it~

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.25%. Comparing base (bc1c96e) to head (459864d). Report is 16 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5255 +/- ## ========================================== - Coverage 28.26% 28.25% -0.01% ========================================== Files 632 632 Lines 43732 43747 +15 ========================================== + Hits 12360 12362 +2 - Misses 30470 30484 +14 + Partials 902 901 -1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/5255/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/5255/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `28.25% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

XiShanYongYe-Chang commented 1 month ago

/cc @zhzhuang-zju

chaosi-zju commented 1 month ago

/retest

XiShanYongYe-Chang commented 1 month ago

/retest

chaosi-zju commented 1 month ago

/retest

zhzhuang-zju commented 1 month ago

/lgtm thanks~

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/karmada-io/karmada/blob/master/test/OWNERS)~~ [XiShanYongYe-Chang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment