karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.37k stars 865 forks source link

flake test: daemonSet status collection testing failed #5258

Closed chaosi-zju closed 3 weeks ago

chaosi-zju commented 1 month ago

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

flake test: daemonSet status collection testing failed

Which issue(s) this PR fixes:

Fixes #5257

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

chaosi-zju commented 1 month ago

/cc @XiShanYongYe-Chang

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.44%. Comparing base (bc1c96e) to head (10f118d). Report is 76 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5258 +/- ## ========================================== + Coverage 28.26% 28.44% +0.18% ========================================== Files 632 632 Lines 43732 43812 +80 ========================================== + Hits 12360 12464 +104 + Misses 30470 30446 -24 Partials 902 902 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/5258/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/5258/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `28.44% <ø> (+0.18%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chaosi-zju commented 1 month ago

/cc @XiShanYongYe-Chang

XiShanYongYe-Chang commented 1 month ago

Is it possible to do the same for other types of resources?

XiShanYongYe-Chang commented 1 month ago

/assign

chaosi-zju commented 1 month ago

Is it possible to do the same for other types of resources?

I search by filtering key words like NumberReady and found just two place.

chaosi-zju commented 3 weeks ago

Do you have any further comments? If you have any other suggestions, please let me know.

karmada-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/karmada-io/karmada/blob/master/test/OWNERS)~~ [XiShanYongYe-Chang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment