Closed zhzhuang-zju closed 1 month ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 0%
with 16 lines
in your changes missing coverage. Please review.
Project coverage is 28.25%. Comparing base (
c38f169
) to head (f24663b
). Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
pkg/detector/detector.go | 0.00% | 16 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @chaunceyjiang @whitewindmills can you help take a review? /cc @chaunceyjiang @whitewindmills
/assign
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: XiShanYongYe-Chang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this? /kind cleanup
What this PR does / why we need it:
Through reviewing the e2e logs, it was found that when deleting
pp/cpp
, there is a chance that cleaning up the labels/annotations of the resource template might fail. To address this, we can add retries to the functionCleanupResourceTemplateMarks
and reduce the scope and impact of these retries.Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: