karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.37k stars 865 forks source link

e2e: clusterresourcebinding permanent-id label #5261

Closed a7i closed 1 month ago

a7i commented 1 month ago

What type of PR is this? /kind cleanup

What this PR does / why we need it:

As described in linked PR, if the label is not set, it could lead to cluster resources being identified as orphaned work and deleted in member clusters. This PR attempts to prevent regressions from happening.

Which issue(s) this PR fixes: Request in PR https://github.com/karmada-io/karmada/pull/5252#issuecomment-2252336961

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.25%. Comparing base (c38f169) to head (b1ce2f1).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5261 +/- ## ======================================= Coverage 28.24% 28.25% ======================================= Files 632 632 Lines 43747 43747 ======================================= + Hits 12357 12359 +2 + Misses 30488 30487 -1 + Partials 902 901 -1 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/5261/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/5261/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `28.25% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

XiShanYongYe-Chang commented 1 month ago

Thanks @a7i /assign

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/karmada-io/karmada/blob/master/test/OWNERS)~~ [XiShanYongYe-Chang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment