karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.37k stars 865 forks source link

Automated cherry pick of #5252: fix: `ClusterResourceBinding` scope in #5262

Closed XiShanYongYe-Chang closed 1 month ago

XiShanYongYe-Chang commented 1 month ago

Cherry pick of #5252 on release-1.10.

5252: fix: ClusterResourceBinding scope in

For details on the cherry pick process, see the cherry pick requests page.

Helm: fix wrong `ClusterResourceBinding` scope in `MutatingWebhookConfiguration`.
XiShanYongYe-Chang commented 1 month ago

/assign @a7i

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.29%. Comparing base (71fa36a) to head (90c8eaf).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.10 #5262 +/- ## ================================================ - Coverage 53.29% 53.29% -0.01% ================================================ Files 253 253 Lines 20576 20576 ================================================ - Hits 10967 10966 -1 - Misses 8882 8883 +1 Partials 727 727 ``` | [Flag](https://app.codecov.io/gh/karmada-io/karmada/pull/5262/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/karmada-io/karmada/pull/5262/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io) | `53.29% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=karmada-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

a7i commented 1 month ago

Thank you! /lgtm

XiShanYongYe-Chang commented 1 month ago

/assign @RainbowMango

karmada-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[charts/OWNERS](https://github.com/karmada-io/karmada/blob/release-1.10/charts/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment