search

karmada-io / karmada

Open, Multi-Cloud, Multi-Cluster Kubernetes Orchestration
https://karmada.io
Apache License 2.0
4.38k stars 867 forks source link

Change etcd liveness probes to the new livez and readyz endpoints #5419

Open liangyuanpeng opened 2 weeks ago

liangyuanpeng commented 2 weeks ago

What would you like to be added:

Using the /livez for LivenessProbe and /readyz for StartupProbe, this is This works for etcd >= v3.5.11, kubeadm has already applied this change, I think the same can be applied on karmada side.

basicly /livez = /health?exclude=NOSPACE&serializable=true and /readyz=/health?serializable=false

The design for the new probes is documented in etcd livez and readyz probes

releated:

Tasks:

Why is this needed:

This is more in line with the kubernetes style.

zhzhuang-zju commented 2 weeks ago

Can other components of Karmada make the same modifications?

liangyuanpeng commented 2 weeks ago

Can other components of Karmada make the same modifications?

Absolutely!

This makes sense for all components, but given that we recently completed the specification of metrics and health detection port parameters https://github.com/karmada-io/karmada/issues/5219, I don't think livez and readyz standardization for karmada components will happen too soon, at least not until version 1.12.