karmada-io / playground

Karmada interactive online environment
Apache License 2.0
8 stars 3 forks source link

add killercoda example: install karmada through CLI #2

Closed JadeFlute0127 closed 1 year ago

JadeFlute0127 commented 1 year ago

Signed-off-by: [JadeFlute0127] [1635468471@qq.com]

What this PR does / why we need it: add killercoda example: install karmada through CLI

Which issue(s) this PR fixes: Part of #1

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


NONE
karmada-bot commented 1 year ago

Welcome @JadeFlute0127! It looks like this is your first PR to karmada-io/playground 🎉

jwcesign commented 1 year ago

Please replace the word Fix with Part of.

JadeFlute0127 commented 1 year ago

I think these problems have been solved~

jwcesign commented 1 year ago

Could you please share the scenario link for your experiment on Killercoda?

JadeFlute0127 commented 1 year ago

Could you please share the scenario link for your experiment on Killercoda?

https://killercoda.com/zhangdiandian/scenario/karmada-CLI-installtion-and-deploy-example

JadeFlute0127 commented 1 year ago

fix done

jwcesign commented 1 year ago

cc @RainbowMango, could you please review this? Overall, it looks good to me.

RainbowMango commented 1 year ago

Sure. /assign

JadeFlute0127 commented 1 year ago

it looks fix done

jwcesign commented 1 year ago

2.Do we need verification for each steps?

I think that the following steps require the completion of the previous steps.

jwcesign commented 1 year ago

/lgtm cc @RainbowMango for final checking

karmada-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/karmada-io/playground/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JadeFlute0127 commented 1 year ago

remove about deploy workload info in intro.md and finish.md

jwcesign commented 1 year ago

/lgtm