search

karmel / homer-idr

Applying IDR analysis to Homer peaks.
15 stars 12 forks source link

not require cwd #1

Open glennsb opened 10 years ago

glennsb commented 10 years ago

A few changes to have the Rscripts learn their own directories to then use that path for them loading other files. This allows the python to then not use cd && style via the shell in the subprocess.check_call().

These were done to make the code to be more easily deployed to somewhere in $PATH for more users & not have to worry about changing directories

karmel commented 10 years ago

Hey, thanks! I totally agree that the cd && is silly. Here's what I'm thinking, though-- the R scripts are pulled straight from the original IDR package (https://sites.google.com/site/anshulkundaje/projects/idr), so while it would be much better to have a fullpath, I would rather not maintain a separate copy of the IDR scripts. Ideally, we would just drop in the most recent version whenever it is updated, without making local changes... Maybe instead of making that change in homer-idr, it makes sense to suggest the change to the IDR mailing list (https://groups.google.com/forum/#!forum/idr-discuss) so that the IDR package maintainer can incorporate it into the master version?

glennsb commented 10 years ago

Good point, I'll try pushing the rscript changes up to idr