Pooled curb client using common_pool lib to prevent "Curl::Err::MultiBadEasyHandle" when using in a multithreaded environment.

karmi / tire-contrib

Additions and extensions for the Tire gem

MIT License

65 stars 31 forks source link

Pooled curb client using common_pool lib to prevent "Curl::Err::MultiBadEasyHandle" when using in a multithreaded environment. #18

Closed brupm closed 11 years ago

brupm commented 11 years ago

Uses https://github.com/jugend/common-pool to allow for high-performance HTTP requests for a multi-threaded environment.
Properly handles Curl::Err::MultiBadEasyHandle
I will write tests if you think there's validity in this PR.

karmi commented 11 years ago

@brupm Cool, I don't think tests are needed, but could you add a short explanation and example as a comment in the file header? A la https://github.com/karmi/tire/blob/master/lib/tire/http/clients/faraday.rb.

brupm commented 11 years ago

Should be good now, thanks @karmi. I have been using this in production for over a day now, no more Curl::Err::MultiBadEasyHandle errors, no noticeable speed difference either.