Add support to :params for custom_filters_score

[volmer]

Just added support to use params with custom_filters_score. Params are often necessary when creating more complex score scripts. For example:

query do
  custom_filters_score do
    query { string 'volmer' }

    params now: Time.now.to_i * 1000

    filter do
      filter 'exists', field: 'created_at'
      script "((0.08 / ((3.16*pow(10,-11)) * abs(now - doc['created_at'].date.getMillis()) + 0.05)))"
    end
  end
end

Thanks to @thor27 and Jon Tai's blog post.

[karmi]

Hi, great.

1/ Can you rewrite the unit test without the tap method? I understand we pull in the ActiveSupport etc, but let's keep unit tests 1.8 friendly.

2/ Can you add a realistic integration test, potentially using your example in the pull request description?

[volmer]

Thanks for the response, @karmi.

Ok, I've removed the tap method from the unit test. Could you please instruct me about where the integration tests for the custom filter score are located? I didn't find them.

[karmi]

Yes, the other queries have just unit tests, I think it's fine to add an example integration test into a separate Should context in the test...

[volmer]

As suggested, I've added a more realistic test (same as the example above) in a separate context.

[Veraticus]

Any chance you can merge this in soon, @karmi? I found myself needing this feature so had to integrate this branch into my project.

[karmi]

Hey, sorry, retouched, merged, pushed!

@volmer I've removed the integration test in the end, since I haven't felt it makes it much clear what's going on :), and added just a simple assert that the param is added to the JSON.

[volmer]

@karmi thanks for merging in!