karmi / tire-contrib

Additions and extensions for the Tire gem
MIT License
65 stars 31 forks source link

Added Custom Filters Score Query support #4

Closed jerryluk closed 12 years ago

jerryluk commented 12 years ago

Hi karmi, Thanks for you email, I have made the changes and added the support in this gem instead of the tire gem. Please take a look and let me know what you think. I would like to know one of the tests in log_subscriber_test.rb is failing and I don't know how to fix it so I would whoever implemented it can fix it.

And, can you please update the README on the main Tire gem to let people know about the functionaries in this gem? Or even provide an example there? I would have used this gem for the more like this query if I can find this out on the main gem. I would hope you can promote this contrib gem more. Thanks!

karmi commented 12 years ago

Hi Jerry, sorry for the delay, merged and released as 0.1.1

karmi commented 12 years ago

Yes, the tire-contrib needs more visibility.

In the end, I think these queries will end up in the core gem, but I'd like to refactor it first, and contrib is currently best way to make them widely available....