search

karnama / vueish

Vue UI Library
MIT License
0 stars 2 forks source link

TextArea: Address placement of scrollbars when using clearable #107

Open fullstackfool opened 3 years ago

fullstackfool commented 3 years ago

Investigate scrollbar styling, especially the textarea.

nandi95 commented 2 years ago

https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-scrollbar it can be styled but not supported by every browser. How should the scrollbar look like?

fullstackfool commented 2 years ago

I think this was originally referring to the styling of the component when a scrollbar was present. For instance, on the TextArea, I believe it was offset from the edge of the component as if there were padding between it and the component border. Similar to the Model body.

Given this issue is a year old it may very well no longer be relevant.

nandi95 commented 2 years ago
Screenshot 2022-06-30 at 14 59 12

It is still closer in the component. This only happens if the component is clearable and the "X" button appears

fullstackfool commented 2 years ago

I would say that's something that should, and could, be addressed by this ticket. I'll update the title for specificity.

nandi95 commented 2 years ago

So you're saying the clear icon should be to the left of the scrollbar? and the text stops at the edge of the clearable?

that might be worse ux as misclicks are easier to happen

fullstackfool commented 2 years ago

The final location of the clear icon, and how it behaves with the text, can be discussed, sure. I've not a suggestion right now on that.

My point is the scrollbar absolutely should not be floating out in whitespace. In any circumstance.

nandi95 commented 2 years ago

I don't think there's a way around it. The clear icons cannot be moved inside the textarea.

If positioning with absolute, the text area itself cannot be styles or hacked for the text to not go under the clear icon.

If you haven't got a suggestion, then I think this could be closed.

fullstackfool commented 2 years ago

I don't have a suggestion at the moment as I'm not working on the issue. It may be we have to address how the clear icon operates globally.

Given the time period this ticket has been open I understand the desire to get it closed, but I don't think this particular styling issue is one we can ignore. I'd go so far as to suggest that the clearable functionality may as well be removed from the TextArea, as we are unlikely to use it due to the resulting design bug.

I'm happy to assign this to myself and attempt a fix, time permitting.

nandi95 commented 2 years ago

I think if you could attempt a fix, or perhaps open a new issue about the clear feature globally then we could progress with this ticket either way.