search

karnov / htmltoword

Ruby html to word gem
MIT License
179 stars 71 forks source link

Fix tests #64

Closed francois2metz closed 6 years ago

francois2metz commented 6 years ago

When running tests on the master branch, I had 2 errors:

Failures:

  1) Htmltoword::Document local_images should only embed local images
     Failure/Error: filename = SecureRandom.urlsafe_base64

     NameError:
       uninitialized constant SecureRandom
     # ./spec/document_spec.rb:28:in `block (3 levels) in <top (required)>'

  2) Bigger and a bit more complex documents transforms other nestings
     Failure/Error: source = Nokogiri::HTML(html.gsub(/>\s+</, '><'))

     ArgumentError:
       invalid byte sequence in US-ASCII
     # ./spec/spec_helper.rb:15:in `gsub'
     # ./spec/spec_helper.rb:15:in `compare_resulting_wordml_with_expected'
     # ./spec/spec_helper.rb:11:in `compare_transformed_files'
     # ./spec/xslt_complex_spec.rb:1244:in `block (2 levels) in <top (required)>'

Finished in 0.52158 seconds (files took 0.1996 seconds to load)
48 examples, 2 failures

I fixed both!

francois2metz commented 6 years ago

What do you think about adding a travis-ci build?

lukelex commented 6 years ago

@francois2metz we'd be down for that. Any specific suggestions?