search

karol-brejna-i / docker-locust

Repository for docker images for locust.io
Apache License 2.0
28 stars 27 forks source link

adds docker hub links #8

Closed lkwg82 closed 5 years ago

lkwg82 commented 5 years ago

fixes #7

karol-brejna-i commented 5 years ago

Oh, man. I love the idea of badges! Never thought about this myself...

On the other hand, before merging the change, I'll ask you to do some small edits.

  1. Let the badges be the first line of the README file.

  2. Move the info about image publication. I intended for the first paragraph of the readme to be a "clean" introduction, to be the very first piece of information on the project (please note, that the readme is also included in docker hub).

On the other hand, the info you had provided ("published images on docker hub") is important. Could you please move it to Usage section (https://github.com/karol-brejna-i/docker-locust/blob/9435c81c4c1dd122f881bd7dbb494e47089c830e/README.md#usage) as a first sentence, for example: "All the images are published on the Docker Hub: https://hub.docker.com/r/grubykarol/locust."

lkwg82 commented 5 years ago

I guess you can easily change in the browser the PR before merging.