search

karolherbst / Gamekeeper-Framework

Library for hooking up game stores and merging them into one single library
GNU Lesser General Public License v2.1
2 stars 0 forks source link

some stuff for #29 #58

Closed karolherbst closed 10 years ago

karolherbst commented 10 years ago

fixes #29 mostly

We could improve the file caching and add some intelligent + error handling, but this isn't that critical now and can be solved through new bugs

karolherbst commented 10 years ago

currently this files the emptyfile download test and I don't know why. The istream object seems to have a filled buffer with "\0", which will produce a 1 byte big file although the sent file is just empty: https://github.com/karolherbst/Gamekeeper-Framework/blob/bug29/tests/core/webserverfiles/emptyfile

It may be related to the embedded webserver or the ArrayBuffer used to read data.

Although I don't care much about emtpy files, it may be confusing to get "\0" by default, even if the download fails in a way or something.

karolherbst commented 10 years ago

I found the issue and try to solve it now