Closed Jookia closed 10 years ago
In general I like the idea, because it is making pch stuff pretty easy for us. I have some notes though:
I've fixed the #includes and added a way to disable Cotire. It's on by default. I'm still working on MinGW support (I need to set up my cross compiler), but I still don't quite understand how to identify single unit compiles...?
I noticed, that single unit compiles are separated targets
I left some comment, but it looks pretty good now.
I've rebased it, made it use
one a little minor thing, but this looks pretty good now. I think I will merge this tomorrow
Fixed.
This fixes #20 in a simple and elegant way, by including Cotire in all the CMake targets. In the future if we want to use single precompiled headers across multiple targets that's possible too, or precompile the Gamekeeper includes, but let's cut to some benchmarks:
Without Cotire:
With Cotire:
With these benchmarks, Cotire effectively halves compile times across the board.
Here's the precompiled header used in gamekeeperCore:
Some issues with this (not pressing):