Declare module for React example

karolis-sh / electron-snowpack

Use Snowpack and esbuild for Electron app development

MIT License

50 stars 8 forks source link

Declare module for React example #28

Closed lauritzsh closed 3 years ago

lauritzsh commented 3 years ago

I noticed there are no types for the package, so I made a quick fix for my own project. I think a better solution would be proper types (maybe even convert it into TypeScript) but this PR should at least do so the React example has no type errors.

karolis-sh commented 3 years ago

Great idea, before adding TypeScript support for main I didn't think that would be needed. Will tackle this with https://github.com/karolis-sh/electron-snowpack/issues/29

lauritzsh commented 3 years ago

I made a better, more general PR at #30. This will at least make the package typed for the user, so the internal stuff can stay JavaScript if preferred. Your project saved me plenty time setting up Electron and Snowpack btw 👍