Integer overflow in case of big matrices

[karoliskoncevicius]

This is a bug reported by @Close-your-eyes via email.

m1 <- matrix(rnorm(100000), nrow=4)                                                                                                                                                                                                 
m2 <- matrix(rnorm(1000000), nrow=4)

row_wilcoxon_twosample(m1, m2)

obs.x  obs.y obs.tot  statistic pvalue location.null alternative exact corrected
1 25000 250000  275000 3130434539     NA             0   two.sided FALSE      TRUE
2 25000 250000  275000 3118218180     NA             0   two.sided FALSE      TRUE
3 25000 250000  275000 3141448608     NA             0   two.sided FALSE      TRUE
4 25000 250000  275000 3117295315     NA             0   two.sided FALSE      TRUE

Warning messages:
1: In nx * ny : NAs produced by integer overflow
2: In nx * ny : NAs produced by integer overflow

This is caused by storing matrix dimensions as integers - then wilcox test multiplies number of observations from both samples together which leads to integer overflow. Solution is to store those values as numeric.

[karoliskoncevicius]

Todo plan:

• [x] check which tests are affected
• [x] create unit tests with really large samples for all functions
• [x] fix the issues

[karoliskoncevicius]

fixed in dev branch: https://github.com/karoliskoncevicius/matrixTests/commit/75142562d4b51766b465cf71496628d2f58a0076