search

karolsluszniak / ex_check

One task to efficiently run all code analysis & testing tools in an Elixir project. Born out of 💜 to Elixir and pragmatism.
https://hex.pm/packages/ex_check
MIT License
305 stars 11 forks source link

feat: Add config directory opt to CLI #21

Closed asummers closed 3 years ago

asummers commented 3 years ago

Resolves #16

Note: I unfolded the __MODULE__ alias expansion because I found grepping for where the EXCheck.Config.* modules were being used was tougher than it should have been, so I resolved this for future folks by making it possible to grep for the fully qualified name of the modules. I can put this back if you'd like, but I think it's a positive change.

I tested this locally, but how would you like this tested for posterity?

asummers commented 3 years ago

Those changes all sound reasonable. Will change accordingly.

karolsluszniak commented 3 years ago

@asummers Merged the others - now this is the last one standing after your pull requesting frenzy :) I'll wait a bit before releasing 0.13 to have this included.

asummers commented 3 years ago

Ack. I will try to clean this PR up this week.

asummers commented 3 years ago

I believe I have addressed all comments.

I just have one outstanding question in https://github.com/karolsluszniak/ex_check/pull/21#discussion_r513152444

I pushed the change to the opt being called --config-file everywhere, pursuant to my suggestion there. I think it communicates the intent, but I am happy to rename if you feel that name is suboptimal.

asummers commented 3 years ago

Sorry for the delays in getting back around on this. Happy to make any more changes and the turnaround should be much quicker =)