New release for scikit-learn installation

karolzak / boxdetect

BoxDetect is a Python package based on OpenCV which allows you to easily detect rectangular shapes like character or checkbox boxes on scanned forms.

MIT License

105 stars 20 forks source link

New release for scikit-learn installation #25

Closed tomityrrell closed 1 year ago

tomityrrell commented 1 year ago

Hello maintainers,

I saw there was a commit recently to replace sklearn with scikit-learn in the repository's requirements, as the former is now deprecated. Will there be a new release (1.0.1?) that includes this change?

Thanks,

Tomi

karolzak commented 1 year ago

Hi @tomityrrell ! Yeah it makes perfect sense to drop a new release. Thanks!

josephcxhxa commented 1 year ago

Hi @karolzak

Version 1.0.1 keeps installing me sklearn instead of scikit-learn.

Maybe it should be also updated in setup.py (https://github.com/karolzak/boxdetect/blob/master/setup.py#L33)

karolzak commented 1 year ago

@josephcxhxa it absolutely should have been updated! Thanks for the heads up - will fix right away and bump version again