search

karolzak / boxdetect

BoxDetect is a Python package based on OpenCV which allows you to easily detect rectangular shapes like character or checkbox boxes on scanned forms.
MIT License
105 stars 20 forks source link

Failure in UnitTests #28

Closed josephcxhxa closed 1 year ago

josephcxhxa commented 1 year ago

Hi!

Been having this issue for a while. Aaside from an extra warning log while running and while running my unit tests, I always got this warning but no major issues locally and with my company Jenkins job.

image image

But recently my Jenkins job started to reject me those tests, so I tested it downloading boxdetect, adding the recomendation from the first image and now everything is working fine!

image image

(The failed test has nothing to do with boxdetect hehe)

karolzak commented 1 year ago

Wow, thank you so much @josephcxhxa You just saved me what could have been hours of scratching my head and investigating the root cause. I noticed that my unit tests started failing after recent update from sklearn->scikit-learn and I was afraid that I will need to make some major changes in the code but it seems like I just had to put dtype=object in 2 places and that solved the issue. Thank you! I now pushed these updates and everything should be working correct in v1.0.2 release