karouani / javasimon

Automatically exported from code.google.com/p/javasimon
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Simon Driver doesn't automatically configure for SQL Server #103

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Connect to MS SQL Server with URL starting with jdbc:simon:sqlserver:
2. Don't specify real driver

What is the expected output? What do you see instead?
- Real driver is not chosen automatically

What version of the product are you using? On what operating system?
3.3.0, any OS/JVM Microsoft SQL Server database only

Original issue reported on code.google.com by gerald.q...@zenika.com on 2 Apr 2013 at 7:40

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r677.

Original comment by gerald.q...@gmail.com on 2 Apr 2013 at 7:48

GoogleCodeExporter commented 8 years ago

Original comment by virgo47 on 2 Apr 2013 at 8:57

GoogleCodeExporter commented 8 years ago
r677 breaks other things - I tested snapshot against our project. Previously 
this datasource in jetty-web.xml worked without problem:
<?xml version="1.0" encoding="UTF-8"?>
<Configure class="org.eclipse.jetty.webapp.WebAppContext">
    <New id="CRUZIntegrationDataSource" class="org.eclipse.jetty.plus.jndi.Resource">
        <Arg>CRUZIntegrationDataSource</Arg>
        <Arg>
            <New class="org.javasimon.jdbcx4.SimonDataSource">
                <Set name="RealDataSourceClassName">oracle.jdbc.pool.OracleDataSource</Set>
                <Set name="Url">jdbc:oracle:thin:@1.1.1.3:1521:SAM</Set>
                <Set name="User">CRUZ_DEV</Set>
                <Set name="Password">whatever</Set>
            </New>
        </Arg>
    </New>
</Configure>

Today it throws:
Caused by: java.lang.IllegalArgumentException: 
jdbc:oracle:thin:@172.16.13.36:1521:SAM is not a Simon JDBC connection URL
    at org.javasimon.jdbc4.SimonConnectionConfiguration.<init>(SimonConnectionConfiguration.java:109)

It was a feature to set up Simon DS with real URL specifying real DS class name 
and it should keep working. Gerald, can you please check it out? Alternativelly 
I can too, but I don't want to mess with changes you made (and I can't test).

Original comment by virgo47 on 30 Apr 2013 at 2:14

GoogleCodeExporter commented 8 years ago
This comment is related to 
https://code.google.com/p/javasimon/issues/detail?id=102 not this issue.

I'll check to see what I can do.

Note: The RealDataSourceClassName property is useless, if you declare the URL 
as jdbc:simon:oracle:thin:@1.1.1.3:1521:SAM

Original comment by gerald.q...@gmail.com on 30 Apr 2013 at 2:40

GoogleCodeExporter commented 8 years ago
r677 regression is fixed

About this issue (incompatibility between Simon/GlassFish and SQLServer), as I 
couldn't reproduce it and no test case was provided. I won't work on it anymore.

Original comment by gerald.q...@gmail.com on 30 Apr 2013 at 9:09

GoogleCodeExporter commented 8 years ago
Considered fixed then.

Original comment by virgo47 on 10 Jun 2013 at 8:13