search

karpathy / nn-zero-to-hero

Neural Networks: Zero to Hero
MIT License
10.9k stars 1.33k forks source link

cmp: adds comparison of shapes #36

Open evgenyfadeev opened 1 year ago

evgenyfadeev commented 1 year ago

Output "shape ok: True/False" if the manual gradient's shape is the same as the autograd gradient shape

smith-kyle commented 5 months ago

I'm a little late to the party, but I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/karpathy/nn-zero-to-hero/pull/36

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.