search

karpetrosyan / hishel

An elegant HTTP Cache implementation for HTTPX and HTTP Core.
https://hishel.com
BSD 3-Clause "New" or "Revised" License
175 stars 22 forks source link

Document default ttl=None #250

Closed Simon-Will closed 4 months ago

Simon-Will commented 4 months ago

As mentioned in #202, I added a sentence to the docs that explains the storage default behavior of not deleting anything when ttl=None.

I was tempted to put it into the top section, since it’s the same for all storages, but I noticed that there were already some duplicated explanations of the ttl, so I just added it there everywhere.

karpetrosyan commented 4 months ago

Thank you very much for the PR :pray: Can we use "until the [controller](link to the controller) decides to remove it" instead of "indefinitely"? I think that will make more sense

Simon-Will commented 4 months ago

Yes, makes sense. I linked to the controllers.md now. Hope that's what you had in mind.