[carrier-integration] Deutsche Post

karrioapi / karrio

Programmable Shipping API (self-hosted)

https://karrio.io

Apache License 2.0

506 stars 94 forks source link

[carrier-integration] Deutsche Post #512

Closed danh91 closed 8 months ago

danh91 commented 8 months ago

feat: setup deutschepost extension as dpdhl API upgrade

ghost commented 8 months ago

👇 Click on the image for a new way to code review

#### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/karrioapi/karrio/512/c0e7360d/426c528dc6a88b836f566e55ee5058f61ab5f3ce.svg)](https://app.codesee.io/r/reviews?pr=512&src=https%3A%2F%2Fgithub.com%2Fkarrioapi%2Fkarrio) #### Legend CodeSee Map legend

MarcoWel commented 8 months ago

Awesome! Only suggestion is to change name from deutschepost to dhl_de, dhl_parcel_de or similar. This API is for DHL Parcel Germany and called DHL Parcel DE Shipping by DHL themselves. Only the service "DHL Warenpost" is handled on the Deutsche Post network (while still being offered as a DHL service) - so deutschepost would be misleading to users.

danh91 commented 8 months ago

Awesome! Only suggestion is to change name from deutschepost to dhl_de, dhl_parcel_de or similar. This API is for DHL Parcel Germany and called DHL Parcel DE Shipping by DHL themselves. Only the service "DHL Warenpost" is handled on the Deutsche Post network (while still being offered as a DHL service) - so deutschepost would be misleading to users.

I completely agree 👍🏿. I will hotfix it since it hasn't been released yet