Open ChrisNolan opened 1 month ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Any comments etc on this? I think you've refactored the dashboard again to use different UIs so maybe that is why you didn't want it? Are there parts I could pull out and keep my own, while other bits (like the received by vs signed by change) that should make it into the core?
Any comments etc on this? I think you've refactored the dashboard again to use different UIs so maybe that is why you didn't want it? Are there parts I could pull out and keep my own, while other bits (like the received by vs signed by change) that should make it into the core?
Hi @ChrisNolan, I thought you said somewhere that it was still a draft and you would let me know when the PR is ready. Haven't looked into your changes since then.
Concerning the dashboard, I am introducing a new dashboard, but it is a project that will live in parallel for a while and only be available to Insiders until it is stable. And one of the main focuses of the new architecture will be for people to customize their dashboards without having merge the changes specific to their needs back to upstream. There will still be a core-shell and reusable components.
Any comments etc on this? I think you've refactored the dashboard again to use different UIs so maybe that is why you didn't want it? Are there parts I could pull out and keep my own, while other bits (like the received by vs signed by change) that should make it into the core?
Hi @ChrisNolan, I thought you said somewhere that it was still a draft and you would let me know when the PR is ready. Haven't looked into your changes since then.
Concerning the dashboard, I am introducing a new dashboard, but it is a project that will live in parallel for a while and only be available to Insiders until it is stable. And one of the main focuses of the new architecture will be for people to customize their dashboards without having merge the changes specific to their needs back to upstream. There will still be a core-shell and reusable components.
Ah, that explains it. Originally I had a question about how to get the signature images to display and you asked to see the code so you had a better sense of what I meant. That was the code that wasn't 'ready'. I posted that and got no comments. Then I rebased and more or less 'finished' it and re-made the PR-- still wanting to know how to access the signature images but at least the data was going to be captured in the mean time. I was also curious about if the move I had made of the logic to signin to get the signature images was put in the right spot (the authentication was failing otherwise).
And the 'tiny' change to 'signed by' to fallback to 'received by' if it was missing is in here too which is much more of a 'bug fix' than any improvement, so that could potentially be moved out into a 'issue' perhaps.
I'll have to look into this 'Insiders' program more closely.