karrioapi / karrio

Programmable Shipping APIs (self-hosted)
https://karrio.io
Apache License 2.0
562 stars 104 forks source link

Fedex tracker updates and dashboard Tracker updates #702

Open ChrisNolan opened 1 month ago

ChrisNolan commented 1 month ago
coderabbitai[bot] commented 1 month ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
ChrisNolan commented 4 days ago

Any comments etc on this? I think you've refactored the dashboard again to use different UIs so maybe that is why you didn't want it? Are there parts I could pull out and keep my own, while other bits (like the received by vs signed by change) that should make it into the core?

danh91 commented 4 days ago

Any comments etc on this? I think you've refactored the dashboard again to use different UIs so maybe that is why you didn't want it? Are there parts I could pull out and keep my own, while other bits (like the received by vs signed by change) that should make it into the core?

Hi @ChrisNolan, I thought you said somewhere that it was still a draft and you would let me know when the PR is ready. Haven't looked into your changes since then.

Concerning the dashboard, I am introducing a new dashboard, but it is a project that will live in parallel for a while and only be available to Insiders until it is stable. And one of the main focuses of the new architecture will be for people to customize their dashboards without having merge the changes specific to their needs back to upstream. There will still be a core-shell and reusable components.

ChrisNolan commented 3 days ago

Any comments etc on this? I think you've refactored the dashboard again to use different UIs so maybe that is why you didn't want it? Are there parts I could pull out and keep my own, while other bits (like the received by vs signed by change) that should make it into the core?

Hi @ChrisNolan, I thought you said somewhere that it was still a draft and you would let me know when the PR is ready. Haven't looked into your changes since then.

Concerning the dashboard, I am introducing a new dashboard, but it is a project that will live in parallel for a while and only be available to Insiders until it is stable. And one of the main focuses of the new architecture will be for people to customize their dashboards without having merge the changes specific to their needs back to upstream. There will still be a core-shell and reusable components.

Ah, that explains it. Originally I had a question about how to get the signature images to display and you asked to see the code so you had a better sense of what I meant. That was the code that wasn't 'ready'. I posted that and got no comments. Then I rebased and more or less 'finished' it and re-made the PR-- still wanting to know how to access the signature images but at least the data was going to be captured in the mean time. I was also curious about if the move I had made of the logic to signin to get the signature images was put in the right spot (the authentication was failing otherwise).

And the 'tiny' change to 'signed by' to fallback to 'received by' if it was missing is in here too which is much more of a 'bug fix' than any improvement, so that could potentially be moved out into a 'issue' perhaps.

I'll have to look into this 'Insiders' program more closely.