search

karrot-dev / karrot-frontend

We migrated to https://codeberg.org/karrot/karrot-frontend
https://codeberg.org/karrot/karrot-frontend
427 stars 178 forks source link

Support link previews #2617

Closed nicksellen closed 1 year ago

nicksellen commented 1 year ago

Request from Robin Foods, to support link previews.

As we are an SPA app with hash-based routing, we can't support it right away.

If you ditch the hash-based routing, then we need to change the backend to serve up the index HTML for most/all pages that are not api requests, or assets, or a few other things.

Although still then, that won't allow us to do any queries as the index HTML is served up by nginx....so I guess we would also need the index page to hit the django app, ... so needs a bit more thought/care to get it to work.

would be nice though!

And a guide here once we've jumped through all those hoops, on how to actually serve nice link previews up --> https://andrejgajdos.com/how-to-create-a-link-preview/

github-actions[bot] commented 1 year ago

This issue is marked as stale because it has not had any activity for 180 days.

If it's still important for you add a comment saying what it means to you, remove the stale label, and/or add the "important" label :)

However, if you just leave it like this, I'll close it in 30 days to help keep your issues relevant!

Thanks!