nicksellen
commented
1 year ago It turns out it's a bit more involved because:
- some email subjects already contain the group name in them [1], would we then have it twice? or change the texts? (then requiring re-translation), or exclude those specific emails from having the group name? (but then it wouldn't look consistent)
- not all emails are in the context of a group
- one-to-one messages don't have a group associated with them
- account related emails, e.g. forgot/reset password, aren't in the context of a group
So, I guess users need to have some understanding that karrot is a thing, and their group on karrot is also a thing.
I looked through my inbox for ideas and saw a few patterns that we could use:
| from | subject |
|---|---|
| Nick via karrot.world | [Foodsharing Foo] blah |
| Nick (via karrot.world) | [Foodsharing Foo] blah |
| Nick from Foodsharing Foo | blah |
| Nick at Foodsharing Foo | blah |
| Nick at Foodsharing Foo via karrot.world | blah |
| Nick via karrot.world | [PM] blah |
| Nick via karrot.world | [Foodsharing Foo] blah |
@brnsolikyl also pointed out there are other things we could do to improve the context of emails, perhaps in the body of the email, perhaps particularly for messages in activity/application/issue chats, to include the context of their associated thing...
[1]
karrot/invitations/templates/emailinvitation.subject.jinja2
1:{% trans group_name=group_name|safe %}Invitation to join {{ group_name }}{% endtrans %}
karrot/groups/templates/user_removal_from_group.subject.jinja2
1:{% trans group_name=group_name|safe%}{{ group_name }} is really missing you!{% endtrans %}
karrot/groups/templates/user_lost_editor_role.subject.jinja2
1:{% trans group_name=group_name|safe %}You lost editing permissions in {{ group_name }}!{% endtrans %}
karrot/groups/templates/user_inactive_in_group.subject.jinja2
1:{% trans group_name=group_name|safe%}{{ group_name }} is missing you!{% endtrans %}
karrot/groups/templates/group_summary.subject.jinja2
1:📊 {% trans group_name=group.name|safe, day=from_date|date %}{{ group_name }} updates for the week of {{ day }}{% endtrans %}
karrot/groups/templates/user_got_role.subject.jinja2
1:{% trans group_name=group_name|safe %}You received a new role in {{ group_name }}!{% endtrans %}
karrot/groups/templates/user_became_editor.subject.jinja2
1:{% trans group_name=group_name|safe %}You gained editing permissions in {{ group_name }}!{% endtrans %}
karrot/applications/templates/application_declined.subject.jinja2
1:❌ {% trans group_name=group.name|safe %}Your application to join {{ group_name }} was declined{% endtrans %}
karrot/applications/templates/new_application.subject.jinja2
1:❓ {% trans user_name=applicant.display_name|safe, group_name=group.name|safe %}{{ user_name }} wants to join {{ group_name }}{% endtrans %}
karrot/applications/templates/application_accepted.subject.jinja2
1:✅ {% trans group_name=group.name|safe %}Your application to join {{ group_name }} was accepted{% endtrans %}
karrot/activities/templates/activity_notification.subject.jinja2
1:📆 {% trans group_name=group.name|safe %}{{ group_name }} upcoming activities{% endtrans %}
github-actions[bot]
Currently we use site name (karrot.world, or dev.karrot.world) as an email subject prefix, but it seems more useful to have the group name instead.
Vasilis and Bruno agreed over here --> https://karrot.world/#/group/191/wall