karrot-dev / karrot-frontend

We migrated to https://codeberg.org/karrot/karrot-frontend
https://codeberg.org/karrot/karrot-frontend
427 stars 178 forks source link

Disable sentry session tracking #2654

Closed nicksellen closed 1 year ago

nicksellen commented 1 year ago

Closes https://community.karrot.world/t/sending-too-much-data-to-sentry/1194

What does this PR do?

I noticed on each page change sentry was sending data such as:

{"sent_at":"2023-06-01T08:03:27.301Z","sdk":{"name":"sentry.javascript.vue","version":"7.50.0"}}
{"type":"session"}
{"sid":"184884223cbc450f8211537dece036a4","init":false,"started":"2023-06-01T08:03:24.339Z","timestamp":"2023-06-01T08:03:27.301Z","status":"exited","errors":0,"attrs":{"release":"b7b00c3d7aebb91a6e13024c4813718aa85394ac","environment":"karrot-dev","user_agent":"Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/112.0"}}

Our intention with sentry was to capture error information, not info on every page load, this feels invasive to me.

Links to related issues

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #2654 (112b0fc) into master (0908a6b) will increase coverage by 23.12%. The diff coverage is 76.01%.

@@             Coverage Diff             @@
##           master    #2654       +/-   ##
===========================================
+ Coverage   52.47%   75.59%   +23.12%     
===========================================
  Files         181      378      +197     
  Lines        4877    40187    +35310     
  Branches      822     2215     +1393     
===========================================
+ Hits         2559    30378    +27819     
- Misses       2318     9809     +7491     
Impacted Files Coverage Δ
src/activities/components/ActivityEdit.stories.js 0.00% <0.00%> (ø)
src/activities/components/ActivityItem.stories.js 0.00% <0.00%> (ø)
src/activities/components/CurrentUser.vue 0.00% <0.00%> (ø)
src/activities/components/PlaceActivities.vue 0.00% <0.00%> (ø)
src/activities/components/ShareDialog.vue 0.00% <0.00%> (ø)
src/activities/pages/PublicActivity.vue 0.00% <0.00%> (ø)
src/agreements/pages/EditAgreement.vue 0.00% <0.00%> (ø)
src/applications/api/applications.js 88.00% <ø> (+88.00%) :arrow_up:
src/applications/components/ApplicationItem.vue 0.00% <0.00%> (ø)
src/applications/components/ApplicationList.vue 0.00% <0.00%> (ø)
... and 147 more

... and 297 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more