Fix attachment niggles - Githubissues

karrot-dev / karrot-frontend

We migrated to https://codeberg.org/karrot/karrot-frontend

https://codeberg.org/karrot/karrot-frontend

428 stars 177 forks source link

Fix attachment niggles #2658

Closed nicksellen closed 1 year ago

nicksellen commented 1 year ago

Branch deployment URL https://fix-attachment-niggles.dev.karrot.world/

What does this PR do?

Resolves issues with attachments reported by @brnsolikyl

I've based it off change/vite branch, as that'll be merged soon and already has one fix in it...

don't set capture attribute on html input (resolved in vite branch)
close gallery by tapping anywhere
hide download button on mobile
- for images, you can still download from the gallery view
- for non-images, it'll open them on clicking, which will probably cause a download if the browser can't handle it anyway

Links to related issues

Checklist

[ ] added a test, or explain why one is not needed/possible...
[ ] no unrelated changes
[ ] asked someone for a code review
[ ] joined #karrot:matrix.org
[ ] added an entry to CHANGELOG.md (description, pull request link, username(s))
[ ] tried out on a mobile device (does everything work as expected on a smaller screen?)